lordgamez commented on code in PR #1583: URL: https://github.com/apache/nifi-minifi-cpp/pull/1583#discussion_r1229841318
########## README.md: ########## @@ -151,6 +151,10 @@ and rebuild. * Lua and development headers -- Required if Lua support is enabled * libgps-dev -- Required if building libGPS support * Zlib headers +* perl -- Required for OpenSSL configuration +* NASM -- Required for OpenSSL only on Windows + +**NOTE** On Windows if Strawberry Perl is used the `${StrawberryPerlRoot}\c\bin` directory should not be part of the %PATH% variable as Strawberry Perl's patch.exe will be found as the patch executable in the configure phase instead if the git patch executable. Review Comment: But don't we only use CMake's cpack? If so we are independent from Chocolatey, so I don't think it should be entirely necessary to note how we can conflict with it, but anyway I can add a note about it to have some additional information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org