lordgamez commented on code in PR #1587:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1587#discussion_r1247640156
##########
docker/test/integration/cluster/checkers/PrometheusChecker.py:
##########
@@ -18,7 +18,16 @@
class PrometheusChecker:
def __init__(self):
- self.prometheus_client =
PrometheusConnect(url="http://localhost:9090";, disable_ssl=True)
+ self.use_ssl = False
+
+ def enable_ssl(self):
+ self.use_ssl = True
+
+ def _getClient(self):
+ if self.use_ssl:
+ return PrometheusConnect(url="https://localhost:9090";,
disable_ssl=True)
Review Comment:
You are right, we don't need it in the Prometheus server, I removed the SSL
config from the server in f360282ef71dcf9645d90dba3f60a5140f8773aa
##########
docker/test/integration/cluster/containers/MinifiContainer.py:
##########
@@ -109,12 +110,16 @@ def _create_properties(self):
if not self.options.enable_provenance:
f.write("nifi.provenance.repository.class.name=NoOpRepository\n")
- if self.options.enable_prometheus:
+ if self.options.enable_prometheus or
self.options.enable_prometheus_with_ssl:
f.write("nifi.metrics.publisher.agent.identifier=Agent1\n")
f.write("nifi.metrics.publisher.class=PrometheusMetricsPublisher\n")
f.write("nifi.metrics.publisher.PrometheusMetricsPublisher.port=9936\n")
f.write("nifi.metrics.publisher.metrics=RepositoryMetrics,QueueMetrics,PutFileMetrics,processorMetrics/Get.*,FlowInformation,DeviceInfoNode,AgentStatus\n")
+ if self.options.enable_prometheus_with_ssl:
+
f.write("nifi.metrics.publisher.PrometheusMetricsPublisher.certificate=/tmp/resources/prometheus-ssl/minifi-cpp-flow.crt\n")
+
f.write("nifi.metrics.publisher.PrometheusMetricsPublisher.ca.certificate=/tmp/resources/prometheus-ssl/root-ca.pem\n")
Review Comment:
Updated in f360282ef71dcf9645d90dba3f60a5140f8773aa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
