mark-bathori commented on code in PR #7449:
URL: https://github.com/apache/nifi/pull/7449#discussion_r1248012824


##########
nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/java/org/apache/nifi/processors/iceberg/AbstractIcebergProcessor.java:
##########
@@ -117,6 +122,15 @@ public void onTrigger(ProcessContext context, 
ProcessSession session) throws Pro
         }
     }
 
+    @Override
+    public String getClassloaderIsolationKey(PropertyContext context) {
+        final KerberosUserService kerberosUserService = 
context.getProperty(KERBEROS_USER_SERVICE).asControllerService(KerberosUserService.class);
+        if (kerberosUserService != null) {
+            return kerberosUserService.getIdentifier();

Review Comment:
   Unfortunately the kerberos principal can't be used here since the controller 
service is not in enabled state when the isolation key is being retrieved so it 
will return with null.
   As I can see the HDFS processors are using the kerberos principal. It works 
properly there due the `dynamicallymodifiesclasspath` which is used on the 
`hadoopConfigPath` property, so the isolation key is going to be evaluated also 
at processor start. This behaviour is missing here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to