szaszm commented on code in PR #1601:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1601#discussion_r1253085830
##########
extensions/windows-event-log/wel/MetadataWalker.cpp:
##########
@@ -171,4 +176,17 @@ void MetadataWalker::updateText(pugi::xml_node &node,
const std::string &field_n
}
}
+void MetadataWalker::updateText(pugi::xml_attribute &node, const std::string
&field_name, std::function<std::string(const std::string &)> &&fn) {
Review Comment:
I think we should pass `fn` without type erasure, since it's all local to
this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
