exceptionfactory commented on code in PR #7575: URL: https://github.com/apache/nifi/pull/7575#discussion_r1284578562
########## nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/FetchGoogleDrive.java: ########## @@ -80,6 +84,62 @@ }) public class FetchGoogleDrive extends AbstractProcessor implements GoogleDriveTrait { + // Google Docs Export Types + private static final AllowableValue EXPORT_MS_WORD = new AllowableValue("application/vnd.openxmlformats-officedocument.wordprocessingml.document", "Microsoft Word"); + private static final AllowableValue EXPORT_OPEN_DOCUMENT = new AllowableValue("application/vnd.oasis.opendocument.text", "OpenDocument"); + private static final AllowableValue EXPORT_PDF = new AllowableValue("application/pdf", "PDF"); + private static final AllowableValue EXPORT_RICH_TEXT = new AllowableValue("application/rtf", "Rich Text"); + private static final AllowableValue EXPORT_EPUB = new AllowableValue("application/epub+zip", "EPUB"); + + // Shared Export Types + private static final AllowableValue EXPORT_HTML_DOC = new AllowableValue("application/zip", "Web Page (HTML)"); + private static final AllowableValue EXPORT_PLAIN_TEXT = new AllowableValue("text/plain", "Plain Text"); + + // Google Spreadsheet Export Types + private static final AllowableValue EXPORT_MS_EXCEL = new AllowableValue("application/vnd.openxmlformats-officedocument.spreadsheetml.sheet", "Microsoft Excel"); + private static final AllowableValue EXPORT_OPEN_SPREADSHEET = new AllowableValue("application/x-vnd.oasis.opendocument.spreadsheet", "OpenDocument Spreadsheet"); + private static final AllowableValue EXPORT_PDF_SPREADSHEET = new AllowableValue("application/pdf", "PDF"); + private static final AllowableValue EXPORT_CSV = new AllowableValue("text/csv", "CSV (first sheet only)", + "Comma-separated values. Only the first sheet will be exported."); + private static final AllowableValue EXPORT_TSV = new AllowableValue("text/tab-separated-values", "TSV (first sheet only)", + "Tab-separate values. Only the first sheet will be exported."); + private static final AllowableValue EXPORT_HTML_SPREADSHEET = new AllowableValue("text/html", "Web Page (HTML)"); + + // Google Presentation Export Types + private static final AllowableValue EXPORT_MS_POWERPOINT = new AllowableValue("application/vnd.openxmlformats-officedocument.presentationml.presentation", "Microsoft PowerPoint"); + private static final AllowableValue EXPORT_OPEN_PRESENTATION = new AllowableValue("application/vnd.oasis.opendocument.presentation", "OpenDocument Presentation"); + private static final AllowableValue EXPORT_PNG = new AllowableValue("image/png", "PNG (first slide only)"); + private static final AllowableValue EXPORT_JPEG = new AllowableValue("image/jpeg", "JPEG (first slide only)"); + private static final AllowableValue EXPORT_SVG = new AllowableValue("image/svg+xml", "SVG (first slide only)", + "Scalable Vector Graphics. Only the first slide will be exported."); + + // Drawings Export Types + private static final AllowableValue EXPORT_PNG_DRAWING = new AllowableValue("image/png", "PNG"); + private static final AllowableValue EXPORT_JPEG_DRAWING = new AllowableValue("image/jpeg", "JPEG"); + private static final AllowableValue EXPORT_SVG_DRAWING = new AllowableValue("image/svg+xml", "SVG"); + + private static final Map<String, String> fileExtensions = new HashMap<>(); + static { + fileExtensions.put("application/vnd.openxmlformats-officedocument.wordprocessingml.document", ".docx"); Review Comment: Thanks for the reply @markap14, that's a good point, and makes sense on further review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org