lordgamez commented on code in PR #1599:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1286959204


##########
libminifi/include/utils/net/AsioSocketUtils.h:
##########
@@ -63,6 +64,64 @@ asio::awaitable<std::tuple<std::error_code>> 
handshake(SslSocket& socket, asio::
 
 
 asio::ssl::context getSslContext(const controllers::SSLContextService& 
ssl_context_service, asio::ssl::context::method ssl_context_method = 
asio::ssl::context::tlsv12_client);
+
+struct SocketData {
+  std::string host = "localhost";
+  int port = -1;
+  std::shared_ptr<minifi::controllers::SSLContextService> ssl_context_service;
+};
+
+class AsioSocketConnection : public io::BaseStream {
+ public:
+  explicit AsioSocketConnection(SocketData socket_data);
+  int initialize() override;
+  size_t read(std::span<std::byte> out_buffer) override {
+    gsl_Expects(stream_);
+    return stream_->read(out_buffer);
+  }
+  size_t write(const uint8_t *value, size_t len) override {
+    gsl_Expects(stream_);
+    return stream_->write(value, len);
+  }

Review Comment:
   Updated in 9c5203b1db3be04c310bc47be0e1199fb0c85102



##########
libminifi/include/core/Processor.h:
##########


Review Comment:
   Updated in 9c5203b1db3be04c310bc47be0e1199fb0c85102



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to