Github user jtstorck commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1301#discussion_r90969482
--- Diff:
nifi-toolkit/nifi-toolkit-zookeeper-migrator/src/main/java/org/apache/nifi/toolkit/zkmigrator/ZooKeeperMigrator.java
---
@@ -284,8 +286,40 @@ private Stat transmitNode(ZooKeeper zooKeeper,
DataStatAclNode node) {
}
private ZooKeeper getZooKeeper(ZooKeeperEndpointConfig
zooKeeperEndpointConfig, AuthMode authMode, byte[] authData) throws IOException
{
+ CountDownLatch connectionLatch = new CountDownLatch(1);
ZooKeeper zooKeeper = new
ZooKeeper(zooKeeperEndpointConfig.getConnectString(), 3000, watchedEvent -> {
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("ZooKeeper server state changed to {} in {}",
watchedEvent.getState(), zooKeeperEndpointConfig);
+ }
+ switch (watchedEvent.getType()) {
+ case None:
+ switch (watchedEvent.getState()) {
+ case SyncConnected:
+ connectionLatch.countDown();
+ break;
+ case Expired:
+ case AuthFailed:
+ case ConnectedReadOnly:
+ case SaslAuthenticated:
+ case Disconnected:
+ break;
+ }
+ }
});
+
+ final boolean connected;
+ try {
+ connected = connectionLatch.await(5, TimeUnit.SECONDS);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ throw new RuntimeException(String.format("interrupted while
waiting for ZooKeeper connection to %s", zooKeeperEndpointConfig), e);
--- End diff --
However, there are other areas in the code that throw RuntimeExceptions.
Could address those in another PR if necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
