gresockj commented on code in PR #7529:
URL: https://github.com/apache/nifi/pull/7529#discussion_r1317049457
##########
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/ConsumeKinesisStream.java:
##########
@@ -292,27 +316,23 @@ public class ConsumeKinesisStream extends
AbstractKinesisStreamProcessor {
)
);
- private static final Map<String, PropertyDescriptor>
DISALLOWED_DYNAMIC_KCL_PROPERTIES = new HashMap<String, PropertyDescriptor>(){{
- put("regionName", REGION);
- put("timestampAtInitialPositionInStream", STREAM_POSITION_TIMESTAMP);
- put("initialPositionInStream", INITIAL_STREAM_POSITION);
- put("dynamoDBEndpoint", DYNAMODB_ENDPOINT_OVERRIDE);
- put("kinesisEndpoint", ENDPOINT_OVERRIDE);
- put("failoverTimeMillis", FAILOVER_TIMEOUT);
- put("gracefulShutdownMillis", GRACEFUL_SHUTDOWN_TIMEOUT);
+ private static final Map<String, PropertyDescriptor>
DISALLOWED_DYNAMIC_KCL_PROPERTIES = new HashMap<>() {{
+ put("leaseManagementConfig.initialPositionInStream",
INITIAL_STREAM_POSITION);
+ put("leaseManagementConfig.failoverTimeMillis", FAILOVER_TIMEOUT);
}};
private static final Object WORKER_LOCK = new Object();
- private static final String WORKER_THREAD_NAME_TEMPLATE =
ConsumeKinesisStream.class.getSimpleName() + "-" + Worker.class.getSimpleName()
+ "-";
+ private static final String SCHEDULER_THREAD_NAME_TEMPLATE =
ConsumeKinesisStream.class.getSimpleName() + "-" +
Scheduler.class.getSimpleName() + "-";
private static final Set<Relationship> RELATIONSHIPS =
Collections.singleton(REL_SUCCESS);
private static final Set<Relationship> RECORD_RELATIONSHIPS =
Collections.unmodifiableSet(new HashSet<>(Arrays.asList(REL_SUCCESS,
REL_PARSE_FAILURE)));
private static final PropertyUtilsBean PROPERTY_UTILS_BEAN;
private static final BeanUtilsBean BEAN_UTILS_BEAN;
+
static {
PROPERTY_UTILS_BEAN = new PropertyUtilsBean();
- PROPERTY_UTILS_BEAN.addBeanIntrospector(new
FluentPropertyBeanIntrospector("with"));
+ PROPERTY_UTILS_BEAN.addBeanIntrospector(new
FluentPropertyBeanIntrospector(""));
Review Comment:
BeanUtils still gives us the benefit of setting the value properly based on
the type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
