levilentz commented on PR #7677:
URL: https://github.com/apache/nifi/pull/7677#issuecomment-1719697784
> @levilentz @mattyb149 @exceptionfactory @MikeThomsen Alternatively I
propose I put up this PR which moves all the things to Groovy 4.x in a few mins
here. And dumps Groovy support from the graph processors. Then you rebase to
that once merged and attempt to restore Groovy support but on the
${nifi.groovy.version} basis which will be Groovy 4.0.15. I was getting an
error about Java 17 which itself is a problem since we're at the very least
Java 17 (though trying to get to Java 21).
>
> How does that sound?
@joewitt obviously I have not been as plugged into this ongoing
conversation, but a couple of thoughts for this specific component:
* This new functionality really needs some sort of JVM injection support, as
that is where the performance gain is from a gremlin-perspective. We have used
groovy because it was the easiest way to interact with:
https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
* From a gremlin perspective, pinning the groovy version is really important
as all the tinkerpop tooling are built on top of specific groovy versions (as
it is all groovy based), so it is causing headaches making specific builds work
when it is pinned to the groovy version in tinkerpop. Therefore, flexibility to
use a specific groovy version in this component would be really neat.
* As for groovy tests, I am already working on refactoring these and
removing all groovy tests
So to get to your proposal, I dont have any issues with that as long as I
have some guidance on how the ExecuteGraphQueryRecordProcessor will work after
that refactor. If you have a PR for me to review that would be immensely
helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
