dan-s1 commented on code in PR #7752: URL: https://github.com/apache/nifi/pull/7752#discussion_r1329278406
########## nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml: ########## @@ -120,28 +120,34 @@ <scope>test</scope> </dependency> <dependency> - <groupId>org.apache.groovy</groupId> + <groupId>org.xmlunit</groupId> + <artifactId>xmlunit-core</artifactId> Review Comment: I believe the output is XML hence there was XML parsing used originally to access the XML. The specific place I use it is in `ScriptedRecordSetWriterTest.testRecordWriterGroovyScript` This was the original code from the Groovy version ``` def xml = new XmlSlurper().parseText(outputStream.toString()) assertEquals('1', xml.record[0].id.toString()) assertEquals('200', xml.record[1].code.toString()) assertEquals('Ramon', xml.record[2].name.toString()) ``` I thought the easiest way to mimic the above was to use XPath to obtain the values and perform the identical assertions. This is the only test in the class. Should we then just delete this class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org