simonbence commented on PR #7661: URL: https://github.com/apache/nifi/pull/7661#issuecomment-1737396683
Hi @exceptionfactory ! Thank you very much for the effort you did put on the review! I added some changes. Also answering your question: ` One general question is whether we should switch the configuration property or keep the json.file property. Relying on the json.file property name would simplify upgrading without having to change property values. On the other hand, it is a simple manual change that seems reasonable. Thoughts? ` I was thinking on this myself as well, but I deciced to use the original property name without remarking the file format because from now on, this should be the default format thus it looks both unnecessary and confusing to highlight this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
