lordgamez commented on code in PR #1669: URL: https://github.com/apache/nifi-minifi-cpp/pull/1669#discussion_r1341030499
########## libminifi/include/utils/file/ArchiveUtils.h: ########## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include <memory> +#include <map> +#include <string> + +#include "io/ArchiveStream.h" +#include "utils/expected.h" +#include "io/BufferStream.h" + +namespace org::apache::nifi::minifi::utils::archive { + +nonstd::expected<std::shared_ptr<io::BufferStream>, std::string> createArchive(std::map<std::string, std::unique_ptr<io::InputStream>>& files, const std::shared_ptr<core::logging::Logger>& logger); Review Comment: I see what you mean, but I don't think it is likely that our utils will be used by other projects, so I would only think in the scope of our project. If we think outside the scope of our current requirements that usually leads to premature generalization which is also a bad practice. But I don't want to go into philosophical discussions, so I would just leave the current helper in the C2Utils :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
