markobean commented on PR #7591: URL: https://github.com/apache/nifi/pull/7591#issuecomment-1743517135
@mtien-apache I have updated the UI elements so that the "Apply recursively" checkbox appears immediately underneath the Process Group Parameter Context combo. I think placing it next to the "Apply" button is too disjointed; it makes more sense to keep the checkbox next to the item to which it applies. @exceptionfactory There is an "Apply" button on both the General and Comments tab. Did your comment of "always visible" mean you wanted to see it on the Controller Services tab as well. I think it is not necessary on that tab. Sure, maybe it's a little inconsistent, but there are no changes that need to be applied on the Controller Services tab; it would serve no functional purpose. Part of the problem may be that the "Apply" button on a Process Group configuration dialog does not dismiss the dialog. It remains present. I have always found that behavior a little odd. I prefer to keep any changes to that as a separate ticket though; I'm not sure if there is a driving reason the dialog should not be dismissed and such a change should be commented on separately, IMO. If you think a change is needed and falls within the scope of this ticket, let me know. Lastly, sorry for the slow reply. I was on vacation and it took a week on top of the time away to get caught up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
