joewitt commented on PR #7830: URL: https://github.com/apache/nifi/pull/7830#issuecomment-1745124928
@exceptionfactory I should add I am not particularly convicted on the byte[]/buffer stuff. Just seems like an opportunity to avoid intermediate copies. My mental model is this stuff could be in some cases fairly high rate and thus we want to be as efficient as we can. I didn't comment on the one related to decompression but it too seemed to be subject to some improvements. I looked at what we're doing in other areas such as this and we have byte[] usage but less so are we jumping between byte buffers to then new byte[] etc.. Ultimately it probably isn't worth looking into now but if we see high utilization and profiling suggests we can do better then we deal with it then. The error I noted and stack trace above I could not get to happen again during testing last night. It suggests some funky state can be entered but I'm not sure of the nature of it. Might well be a problem with the agent itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
