NissimShiman commented on PR #7781: URL: https://github.com/apache/nifi/pull/7781#issuecomment-1753414850
Thank you for this last suggestion, @exceptionfactory . This will work nicely with the 2.0 branch. Regarding a jira/PR for the 1.x branch, I'm not sure the idea having the three `Config Strategy` options (i.e. `Preset`, `Replace`, `Merge`) with `Replace` as default will work as smoothly as desired, as we will have an interesting edge case where an out of the box processor will have `Config File` and `Config Body` empty as well. I think the only way to interpret this is like `Preset`, but then that leads to different ways to configure for default settings, one where `Preset` is set specifically and one where we have `Replace` set but no custom configuration has been provided, So I think for 1.x, we either we go with most recent commit before this (i.e. before putting in the `Preset` option, notwithstanding your most recent comment) or we go with `Replace` as default, and we are OK with this being interpreted as default tika configuration when no custom configuration has been provided. (There is one other option - which is to invalidate the processor when we have `Replace` with no custom configuration, but that will hurt backward compatibility.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
