pvillard31 commented on code in PR #7891:
URL: https://github.com/apache/nifi/pull/7891#discussion_r1366712339


##########
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java:
##########
@@ -1165,13 +1168,22 @@ public void start(final boolean monitor) throws 
IOException {
 
         nifiPropsFilename = nifiPropsFilename.trim();
 
+        String xmx = null;
+        String xms = null;
+
         final List<String> javaAdditionalArgs = new ArrayList<>();
         for (final Map.Entry<String, String> entry : props.entrySet()) {
             final String key = entry.getKey();
             final String value = entry.getValue();
 
             if (key.startsWith("java.arg")) {
                 javaAdditionalArgs.add(value);
+                if(value.toLowerCase().startsWith("-xms")) {

Review Comment:
   One could be configuring NiFi using -Xms and -Xmx, no? The default being:
   ````
   java.arg.2=-Xms1g
   java.arg.3=-Xmx1g
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to