exceptionfactory commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1367234754
##########
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonParserFactory.java:
##########
@@ -23,27 +23,20 @@
import java.io.IOException;
import java.io.InputStream;
+import java.util.Objects;
-public class JsonParserFactory implements TokenParserFactory{
- private static final JsonFactory JSON_FACTORY = new JsonFactory();
- private static final ObjectMapper JSON_MAPPER = new ObjectMapper();
-
+public class JsonParserFactory implements TokenParserFactory {
@Override
- public JsonParser getJsonParser(InputStream in) throws IOException {
- JsonParser jsonParser = JSON_FACTORY.createParser(in);
- jsonParser.setCodec(JSON_MAPPER);
-
- return jsonParser;
- }
+ public JsonParser getJsonParser(final InputStream in, final
StreamReadConstraints streamReadConstraints, final boolean allowComments)
throws IOException {
+ Objects.requireNonNull(in, "Input Stream required");
+ Objects.requireNonNull(streamReadConstraints, "Stream Read Constraints
required");
- @Override
- public ObjectMapper createCodec(boolean allowComments,
StreamReadConstraints streamReadConstraints) {
- ObjectMapper codec = new ObjectMapper();
- if(allowComments) {
- codec.enable(JsonParser.Feature.ALLOW_COMMENTS);
+ final ObjectMapper objectMapper = new ObjectMapper();
+
objectMapper.getFactory().setStreamReadConstraints(streamReadConstraints);
+ if (allowComments) {
+ objectMapper.enable(JsonParser.Feature.ALLOW_COMMENTS);
}
- codec.getFactory().setStreamReadConstraints(streamReadConstraints);
-
- return codec;
+ final JsonFactory jsonFactory = objectMapper.getFactory();
+ return jsonFactory.createParser(in);
Review Comment:
Thanks for noting the previous approach. The line calling `setCodec()` was
unchanged in the most recent updates for NIFI-12153, but it actually should
have been removed as part of the changes to incorporate the constraint
settings. So in this case, it is an opportunity to correct the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
