exceptionfactory commented on code in PR #7874: URL: https://github.com/apache/nifi/pull/7874#discussion_r1370197548
########## nifi-mock/src/main/java/org/apache/nifi/util/MockPropertyConfiguration.java: ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.util; + +import org.apache.nifi.migration.PropertyConfiguration; + +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.UUID; + +public class MockPropertyConfiguration implements PropertyConfiguration { + private final Map<String, String> propertyRenames = new HashMap<>(); + private final Set<String> propertiesRemoved = new HashSet<>(); + private final Set<String> propertiesUpdated = new HashSet<>(); + private final Map<String, String> rawProperties; + private final Set<CreatedControllerService> createdControllerServices = new HashSet<>(); Review Comment: Thanks for the reply. For additional background, in the past we received some pull requests flagging potential issues surfaced through the [NonDex](https://github.com/TestingResearchIllinois/NonDex) tool, which introduces randomness for certain collections to highlight the impact of element ordering. This exercise is admittedly somewhat contrived. I agree that tests and runtime code should not depend on the ordering of properties changed, which could surface through calls to method that return a Map of keys and values. With that background, I am fine with leaving the implementation as it is for now, and we could revisit later if necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
