martinzink commented on code in PR #1693:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1693#discussion_r1371429026
##########
libminifi/include/core/Processor.h:
##########
@@ -180,25 +180,24 @@ class Processor : public Connectable, public
ConfigurableComponent, public state
bool addConnection(Connectable* connection);
- virtual void onTrigger(const std::shared_ptr<ProcessContext> &context, const
std::shared_ptr<ProcessSessionFactory> &sessionFactory);
- void onTrigger(ProcessContext *context, ProcessSessionFactory
*sessionFactory);
-
bool canEdit() override {
return !isRunning();
}
- virtual void onTrigger(const std::shared_ptr<ProcessContext> &context, const
std::shared_ptr<ProcessSession> &session) {
- onTrigger(context.get(), session.get());
- }
- virtual void onTrigger(ProcessContext* /*context*/, ProcessSession*
/*session*/) {
- }
void initialize() override {
}
- virtual void onSchedule(const std::shared_ptr<ProcessContext> &context,
const std::shared_ptr<ProcessSessionFactory> &sessionFactory) {
- onSchedule(context.get(), sessionFactory.get());
+
+ virtual void onTrigger(const std::shared_ptr<ProcessContext>& context, const
std::shared_ptr<ProcessSessionFactory>& session_factory);
+
+ virtual void onTrigger_2(const std::shared_ptr<ProcessContext>& context,
const std::shared_ptr<ProcessSession>& session) {
Review Comment:
I couldnt come up with a better name yet, I've changed it from onTrigger so
its easier to find the remaining occurences where we rely on shared_ptr-s
We could either revert this back to onTrigger or come up with a slightly
better name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
