ChrisSamo632 commented on code in PR #7913: URL: https://github.com/apache/nifi/pull/7913#discussion_r1373292964
########## nifi-nar-bundles/nifi-apicurio-bundle/nifi-apicurio-schema-registry-service/src/main/java/org/apache/nifi/apicurio/schemaregistry/util/SchemaUtils.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.apicurio.schemaregistry.util; + +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.avro.Schema; +import org.apache.avro.SchemaParseException; +import org.apache.nifi.avro.AvroTypeUtil; +import org.apache.nifi.schema.access.SchemaNotFoundException; +import org.apache.nifi.serialization.record.RecordSchema; +import org.apache.nifi.serialization.record.SchemaIdentifier; + +import java.io.IOException; +import java.io.InputStream; +import java.io.UncheckedIOException; + +public class SchemaUtils { + private static final ObjectMapper OBJECT_MAPPER = setObjectMapper(); + + private SchemaUtils() { + } + + public static RecordSchema createRecordSchema(final InputStream schemaStream, final String name, final int version) throws SchemaNotFoundException, IOException { + final JsonNode schemaNode = OBJECT_MAPPER.readTree(schemaStream); + final String schemaText = schemaNode.toString(); + + try { + final Schema avroSchema = new Schema.Parser().parse(schemaText); + final SchemaIdentifier schemaId = SchemaIdentifier.builder() + .name(name) + .version(version) + .build(); + return AvroTypeUtil.createSchema(avroSchema, schemaText, schemaId); + } catch (final SchemaParseException spe) { + throw new SchemaNotFoundException("Obtained Schema with name " + name Review Comment: At least log the `SchemaParseException`, it might well contain useful information such as details of what's invalid in the schema being parsed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
