ferencerdei commented on code in PR #8028:
URL: https://github.com/apache/nifi/pull/8028#discussion_r1395655853
##########
minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-framework-core/src/main/java/org/apache/nifi/minifi/c2/command/DefaultUpdateConfigurationStrategy.java:
##########
@@ -90,11 +93,12 @@ public boolean update(byte[] rawFlow) {
}
try {
- byte[] enrichedFlowCandidate =
flowEnrichService.enrichFlow(rawFlow);
+ byte[] propertyEncryptedRawDataFlow =
flowPropertyEncryptor.encryptSensitiveProperties(rawFlow);
Review Comment:
Shouldn't we enrich the flow first and encrypt properties after? Now the
properties that are set for example in the sslControllerServiceProperties
method won't be encrypted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
