rfellows commented on code in PR #8053:
URL: https://github.com/apache/nifi/pull/8053#discussion_r1406142353


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/package.json:
##########
@@ -6,7 +6,7 @@
         "start": "ng serve",
         "build": "ng build",
         "watch": "ng build --watch --configuration development",
-        "test": "ng test",
+        "test": "ng test --karma-config=karma.conf.js",

Review Comment:
   @mcgilman,
   Currently, running `npm run test` just hangs and doesn't complete. We have a 
few options:
   * update this script to: `"test": "ng test --karma-config=karma.conf.js 
--watch=false",`
   * add another script: `"test-no-watch": "ng test 
--karma-config=karma.conf.js --watch=false",`
   * update the karma.conf.js to specify this is a `singleRun` test by adding 
`singleRun: true`
   * add another karma configuration for the singleRun of tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to