EndzeitBegins commented on PR #8102:
URL: https://github.com/apache/nifi/pull/8102#issuecomment-1837946154

   Thank you for your feedback @exceptionfactory and @markap14.
   
   I renamed `defaultDescribedValue(DescribedValue)` to 
`defaultValue(DescribedValue)` making it an overload of the existing 
`defaultValue(String)`.
   
   In this process I also removed all calls to `defaultValue` that statically 
provide `null` I could find in the codebase.  All these calls were effectively 
doing nothing, as the existing implementation of `defaultValue` just returns 
the `PropertyDescriptor.Builder` without any modification upon receiving 
`null`. 
   I assumed this is a more straightforward change than keeping the calls but 
as `defaultValue((String) null)`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to