szaszm commented on code in PR #1703: URL: https://github.com/apache/nifi-minifi-cpp/pull/1703#discussion_r1414716543
########## libminifi/src/core/extension/ExtensionManager.cpp: ########## @@ -72,9 +72,13 @@ bool ExtensionManager::initialize(const std::shared_ptr<Configure>& config) { })); for (const auto& candidate : candidates) { auto library = internal::asDynamicLibrary(candidate); - if (!library || !library->verify(logger_)) { + if (!library) { continue; } + if (!library->verify(logger_)) { + logger_->log_warn("Skipping library '{}' at '{}': failed verification, different build?", + library->name, library->getFullPath()); + } Review Comment: Yup, that was an oversight, thanks for catching it. fixed in [bdf1cd3](https://github.com/apache/nifi-minifi-cpp/pull/1703/commits/bdf1cd3b5f27b9c4d759ebc23b1a05c259905ef9) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org