exceptionfactory commented on code in PR #78: URL: https://github.com/apache/nifi-site/pull/78#discussion_r1424767986
########## content/projects/minifi/minifi-toolkit.md: ########## @@ -1,7 +1,10 @@ --- title: Apache NiFi MiNiFi Toolkit Guide -menu: minifi-topbar.html -containerEnabled: true +menu: + main: + parent: "MiNiFi" + name: Toolkit Guide Review Comment: The MiNiFi Toolkit Guide page does not have much detail and is far out of date. This is a good opportunity to remove the page completely. Future efforts could evaluate a replacement, but it should be removed as part of this redesign. ########## content/documentation/faq.md: ########## @@ -1,6 +1,10 @@ --- title: Apache NiFi FAQ -containerEnabled: true +menu: + main: + name: NiFi FAQ Review Comment: The FAQ page does not add much value as it is limited primary to documentation links. Recommend removing it as part of this redesign. ########## content/documentation/security.md: ########## @@ -1,9 +1,13 @@ --- title: Apache NiFi Security -containerEnabled: true +menu: + main: + name: NiFi Security Review Comment: Following recent updates, recommend naming this page `Security Reporting`, as it now includes NiFi and NiFi Registry. ########## content/download/_index.md: ########## @@ -0,0 +1,197 @@ +--- +title: "Download" +--- + +# Download + +Previous releases are available in [release archives](https://archive.apache.org/dist/nifi/). Archive downloads are +subject to rate limiting. + +OpenPGP [Project Keys](https://downloads.apache.org/nifi/KEYS) can be used for +[download verification](https://www.apache.org/info/verification.html). + +## Apache NiFi {{< param currentProjectVersion >}} + +- Released: {{< param currentProjectVersionReleased >}} +- <a href="https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version{{< param currentProjectVersion >}}">Release Notes</a> +- [Migration Guidance](https://cwiki.apache.org/confluence/display/NIFI/Migration+Guidance) + +<div class="uk-card uk-card-default uk-margin-top"> + <div class="uk-card-body"> + <h3>Sources</h3> + <div class="uk-margin-top uk-flex"> + <div> + <a class="uk-button uk-button-primary uk-button-small" + href="https://www.apache.org/dyn/closer.lua?path=/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip"> + Download + </a> + </div> + <div class="uk-width-1-3 uk-margin-left">nifi-{{< param currentProjectVersion >}}-source-release.zip</div> + <div class="uk-width-1-1 uk-flex uk-flex-right"> + <a class="uk-button uk-button-default uk-button-small" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.asc"> + OpenPGP + </a> + <a class="uk-button uk-button-default uk-button-small uk-margin-small-left" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.sha512"> + SHA-512 + </a> + <a class="uk-button uk-button-default uk-button-small uk-margin-small-left" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.sha256"> + SHA-256 + </a> + </div> + </div> + </div> +</div> + +<div class="uk-card uk-card-default uk-margin-top"> + <div class="uk-card-body"> + <h3>Standard</h3> + <div class="uk-margin-top uk-flex"> + <div> + <a class="uk-button uk-button-primary uk-button-small" + href="https://www.apache.org/dyn/closer.lua?path=/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip"> + Download + </a> + </div> + <div class="uk-width-1-3 uk-margin-left">nifi-{{< param currentProjectVersion >}}-bin.zip</div> + <div class="uk-width-1-1 uk-flex uk-flex-right"> + <a class="uk-button uk-button-default uk-button-small" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.asc"> + OpenPGP + </a> + <a class="uk-button uk-button-default uk-button-small uk-margin-small-left" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.sha512"> + SHA-512 + </a> + <a class="uk-button uk-button-default uk-button-small uk-margin-small-left" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.sha256"> + SHA-256 + </a> + </div> + </div> + </div> +</div> + +<div class="uk-card uk-card-default uk-margin-top"> + <div class="uk-card-body"> + <h3>Stateless</h3> + <div class="uk-margin-top uk-flex"> + <div> + <a class="uk-button uk-button-primary uk-button-small" + href="https://www.apache.org/dyn/closer.lua?path=/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip"> + Download + </a> + </div> + <div class="uk-width-1-3 uk-margin-left">nifi-stateless-{{< param currentProjectVersion >}}-bin.zip</div> + <div class="uk-width-1-1 uk-flex uk-flex-right"> + <a class="uk-button uk-button-default uk-button-small" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.asc"> + OpenPGP + </a> + <a class="uk-button uk-button-default uk-button-small uk-margin-small-left" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.sha512"> + SHA-512 + </a> + <a class="uk-button uk-button-default uk-button-small uk-margin-small-left" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.sha256"> + SHA-256 + </a> + </div> + </div> + </div> +</div> + +<div class="uk-card uk-card-default uk-margin-top"> + <div class="uk-card-body"> + <h3>Kafka Connector</h3> + <div class="uk-margin-top uk-flex"> + <div> + <a class="uk-button uk-button-primary uk-button-small" + href="https://www.apache.org/dyn/closer.lua?path=/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip"> + Download + </a> + </div> + <div class="uk-width-1-2 uk-margin-left">nifi-kafka-connector-assembly-{{< param currentProjectVersion >}}.zip</div> + <div class="uk-width-1-1 uk-flex uk-flex-right"> + <a class="uk-button uk-button-default uk-button-small" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.asc"> + OpenPGP + </a> + <a class="uk-button uk-button-default uk-button-small uk-margin-small-left" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.sha512"> + SHA-512 + </a> + <a class="uk-button uk-button-default uk-button-small uk-margin-small-left" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.sha256"> + SHA-256 + </a> + </div> + </div> + </div> +</div> + +<div class="uk-card uk-card-default uk-margin-top"> + <div class="uk-card-body"> + <h3>Toolkit</h3> + <div class="uk-margin-top uk-flex"> + <div> + <a class="uk-button uk-button-primary uk-button-small" + href="https://www.apache.org/dyn/closer.lua?path=/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip"> + Download + </a> + </div> + <div class="uk-width-1-2 uk-margin-left">nifi-toolkit-{{< param currentProjectVersion >}}-bin.zip</div> + <div class="uk-width-1-1 uk-flex uk-flex-right"> + <a class="uk-button uk-button-default uk-button-small" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.asc"> + OpenPGP + </a> + <a class="uk-button uk-button-default uk-button-small uk-margin-small-left" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.sha512"> + SHA-512 + </a> + <a class="uk-button uk-button-default uk-button-small uk-margin-small-left" + href="https://downloads.apache.org/nifi/{{< param currentProjectVersion >}}/nifi-{{< param currentProjectVersion >}}-source-release.zip.sha256"> + SHA-256 + </a> + </div> + </div> + </div> +</div> + +## Apache NiFi {{< param previousProjectVersion >}} + +- Released: {{< param previousProjectVersionReleased >}} +- <a href="https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version{{< param previousProjectVersion >}}">Release Notes</a> +- [Migration Guidance](https://cwiki.apache.org/confluence/display/NIFI/Migration+Guidance) + +<div class="uk-card uk-card-default uk-margin-top"> + <div class="uk-card-body"> + <h3>Sources</h3> + <div class="uk-margin-top uk-flex"> + <div> + <a class="uk-button uk-button-primary uk-button-small" + href="https://www.apache.org/dyn/closer.lua?path=/nifi/{{< param previousProjectVersion >}}/nifi-{{< param previousProjectVersion >}}-source-release.zip"> Review Comment: The download links for the previous version should include all the artifacts as opposed to just to the source link. ########## content/projects/minifi/source.md: ########## @@ -0,0 +1,21 @@ +--- +title: Apache NiFi MiNiFi Sources Review Comment: Rather than having the MiNiFi Sources on a separate page, this should be combined together with the Downloads page. Given that NiFi, NiFi Registry, and MiNiFi Java are all located and versioned in the same Git repository, it seems like this is a good opportunity to centralized all downloads for all products on one Downloads page, instead of links on various pages. ########## content/download/_index.md: ########## @@ -0,0 +1,197 @@ +--- +title: "Download" +--- + +# Download + +Previous releases are available in [release archives](https://archive.apache.org/dist/nifi/). Archive downloads are +subject to rate limiting. + +OpenPGP [Project Keys](https://downloads.apache.org/nifi/KEYS) can be used for +[download verification](https://www.apache.org/info/verification.html). + +## Apache NiFi {{< param currentProjectVersion >}} + +- Released: {{< param currentProjectVersionReleased >}} +- <a href="https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version{{< param currentProjectVersion >}}">Release Notes</a> +- [Migration Guidance](https://cwiki.apache.org/confluence/display/NIFI/Migration+Guidance) + +<div class="uk-card uk-card-default uk-margin-top"> Review Comment: Each download section should be converted to a partial template for reusability. It is worth spending some time on the size and layout of each downloadable file, attempting to improve the usability and functionality. It is important to make the primary download action clear, while also being able to download the GPG signatures and file hashes if desired. ########## content/documentation/videos.md: ########## @@ -1,9 +1,13 @@ --- title: Apache NiFi Videos -containerEnabled: true +menu: + main: + name: NiFi Videos + parent: "Documentation" + weight: 4 --- -# Apache <span class="ni">ni</span><span class="fi">fi</span> Videos +# Apache {{< project-label >}} Videos ## Conference Presentations Review Comment: The header sizing of each video title seems too large in proportion to everything else, so it would be helpful to the reduce the header sizing for videos. ########## content/documentation/_index.md: ########## @@ -0,0 +1,9 @@ +--- +title: "Documentation" +layout: "documentation" Review Comment: As the documentation embeds an iframe of the generated documentation, this is one case where it would be helpful to maintain the full available width of the browser, as opposed to the constrained container view, which works well for other pages. ########## content/development/quickstart.md: ########## @@ -1,9 +1,13 @@ --- -title: Apache NiFi Development Quickstart -containerEnabled: true +title: Apache NiFi Development Quickstart Review Comment: The Quickstart guide is out of date in several areas, and does not provide much in the way of value beyond the project README.md. It seems best to remove this page completely, as anyone interested in getting started with development should view the README.md on GitHub to get started. ########## content/_index.md: ########## @@ -0,0 +1,37 @@ +--- +title: "Apache NiFi" +--- + +{{% hero-section img=main-hero.png %}} +# An **easy to use**, **powerful**, and **reliable** system to process and distribute data +Apache NiFi provides configurable, scalable, and reliable data transformation and distribution + +<a class="uk-button uk-button-primary uk-icon" href="/download/">Download</a> +<a class="uk-button uk-button-default uk-icon" href="/download/"> View Documentation</a> +{{% /hero-section %}} + +{{% hero-section img=provenance.png background=white %}} Review Comment: The various images seem slightly blurry, which might be an artifact of the export or generation process. Recommend revisiting the images on the home page so that the text is clear and sharp. ########## content/community/_index.md: ########## @@ -0,0 +1,117 @@ +--- +title: "Community" +menu: + main: + weight: 3 +--- + +# {{< project-label >}} Team Review Comment: Recommend adding `Apache` for consistency with other pages: ```suggestion # Apache {{< project-label >}} Team ``` ########## config.toml: ########## @@ -51,3 +32,84 @@ currentProjectVersion = "2.0.0-M1" currentProjectVersionReleased = "2023-11-25" previousProjectVersion = "1.24.0" previousProjectVersionReleased = "2023-11-27" + +[menu] + [[menu.main]] + name = 'NiFi Documentation' + url = '/documentation' + weight = -1 + parent = 'Documentation' + [[menu.main]] + name = 'NiFi Wiki' + url = 'https://cwiki.apache.org/confluence/display/NIFI' + weight = 10 + parent = 'Documentation' + [menu.main.params] + external = true + [[menu.right]] + name = 'Release Notes' + url = 'https://cwiki.apache.org/confluence/display/NIFI/Release+Notes' + weight = -1 + parent = 'Downloads' + [menu.right.params] + external = true + [[menu.right]] + name = 'GitHub' + url = 'https://github.com/apache/nifi' + [menu.right.params] + external = true + [[menu.main]] + name = 'Contributor Guide' + url = 'https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide' + weight = 10 + parent = 'Community' Review Comment: It seems like the `Contributor Guide` would fit better under the `Development` section, along with the other guides. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org