markap14 commented on code in PR #8158:
URL: https://github.com/apache/nifi/pull/8158#discussion_r1426763124
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/pom.xml:
##########
@@ -252,6 +252,8 @@
<nifi.analytics.connection.model.implementation>org.apache.nifi.controller.status.analytics.models.OrdinaryLeastSquares</nifi.analytics.connection.model.implementation>
<nifi.analytics.connection.model.score.name>rSquared</nifi.analytics.connection.model.score.name>
<nifi.analytics.connection.model.score.threshold>.90</nifi.analytics.connection.model.score.threshold>
+ <nifi.analytics.prediction.parallel.processing.timeout>60
secs</nifi.analytics.prediction.parallel.processing.timeout>
Review Comment:
I would avoid adding new properties for this. Instead, recommend just
hard-coding the number of threads to some value like 4. And wait up to
`nifi.web.request.timeout` amount of time.
I can't see anyone really having a need to configure these properties, and
the more that we add, the more overwhelming it is to configure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
