fgerlits commented on code in PR #1708:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1708#discussion_r1444320712
##########
libminifi/src/core/flow/StructuredConfiguration.cpp:
##########
@@ -620,20 +628,26 @@ void StructuredConfiguration::parseRPGPort(const Node&
port_node, core::ProcessG
}
void StructuredConfiguration::parsePropertyValueSequence(const std::string&
property_name, const Node& property_value_node, core::ConfigurableComponent&
component) {
+ core::Property myProp(property_name, "", "");
+ component.getProperty(property_name, myProp);
+
for (const auto& nodeVal : property_value_node) {
if (nodeVal) {
Node propertiesNode = nodeVal["value"];
- // must insert the sequence in differently.
- const auto rawValueString = propertiesNode.getString().value();
- logger_->log_debug("Found {}={}", property_name, rawValueString);
+ auto rawValueString = propertiesNode.getString().value();
+ if (myProp.isSensitive()) {
+ rawValueString = decryptProperty(rawValueString);
+ }
+ logger_->log_debug("Found property {}", property_name);
Review Comment:
Yes, good point. We could even make the change now; the one drawback is
that no properties would be allowed to start with `enc{` and end with `}`. I
don't know if that is a big problem. Alternatively, we could introduce a new
(and possibly temporary) `wasSensitive()` flag if/when we change a property
from sensitive to non-sensitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
