[
https://issues.apache.org/jira/browse/NIFI-12554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804447#comment-17804447
]
Daniel Stieglitz edited comment on NIFI-12554 at 1/8/24 9:42 PM:
-----------------------------------------------------------------
[~exceptionfactory] Another thing I would like to do as part of pulling up the
common pieces of code found in JoltTransformJSON and JoltTransformRecord is
pull up the common properties found in both processors. The following
properties are identical except for their name values.
||Property||Name in JoltTransformJSON||Name in JoltTransformRecord||
|JOLT_TRANSFORM|jolt-transform|jolt-record-transform|
|JOLT_SPEC|jolt-spec|jolt-record-spec|
|CUSTOM_CLASS|jolt-custom-class|jolt-record-custom-class|
|MODULES|jolt-custom-modules|jolt-record-custom-modules|
|TRANSFORM_CACHE_SIZE|Transform Cache Size|jolt-record-transform-cache-size|
Can I still pull them up and just use the names for the properties found in
JoltTransformJSON? Would this be included in what you described in the epic
{quote}
Moving Processors and Controller Services changes class names and bundle
coordinates which will break existing flow configurations.
{quote}
was (Author: JIRAUSER294662):
[~exceptionfactory] Another thing I would like to do as part of pulling up the
common pieces of code found in JoltTransformJSON and JoltTransformRecord is
pull up the common properties found in both processors. The following
properties are identical except for their name values.
||Property||Name in JoltTransformJSON||Name in JoltTransformRecord||
|JOLT_TRANSFORM|jolt-transform|jolt-record-transform|
|JOLT_SPEC|jolt-spec|jolt-record-spec|
|CUSTOM_CLASS|jolt-custom-class|jolt-record-custom-class|
|MODULES|jolt-custom-modules|jolt-record-custom-modules|
|TRANSFORM_CACHE_SIZE|Transform Cache Size|jolt-record-transform-cache-size|
Can I still pull them up and just use the names for the properties found in
JoltTransformJSON?
> Refactor JoltTransformJSON and JoltTransformRecord processors in order to
> reduce duplicate code
> -----------------------------------------------------------------------------------------------
>
> Key: NIFI-12554
> URL: https://issues.apache.org/jira/browse/NIFI-12554
> Project: Apache NiFi
> Issue Type: Sub-task
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Major
>
> There is a lot of duplicate code between the JoltTransformJSON and
> JoltTransformRecord processors. As a result each time there is a bug
> discovered in the duplicate code there has to be a fix applied in both places
> (e.g. NIFI-11959 and NIFI-12165). This ticket aims to pull up the common
> code between JoltTransformJSON and JoltTransformRecord similar to what has
> been done for PutElastisearchJSON and PutElastisearchRecord processors with
> the creation of AbstractPutElasticsearch.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
