exceptionfactory commented on code in PR #8184:
URL: https://github.com/apache/nifi/pull/8184#discussion_r1451043360
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java:
##########
@@ -1433,6 +1434,14 @@ private Map<String, String> populatePropertiesMap(final
ComponentNode componentN
final String serviceVersionedComponentId =
proposedProperties.get(propertyName);
String instanceId =
getServiceInstanceId(serviceVersionedComponentId, group);
value = (instanceId == null) ?
serviceVersionedComponentId : instanceId;
+
+ // Find the same property descriptor in the
component's CreatedExtension and replace it with the
+ // instance ID of the service
+ createdExtensions.stream().filter(ce ->
ce.extension.equals(componentNode)).forEach(createdExtension -> {
+ LOG.debug("Replacing CreatedExtension property {}
old value {} with new value {}",
+ propertyName,
createdExtension.propertyValues.get(propertyName) , value);
Review Comment:
This debug log should be removed because property values may contain
sensitive information that should not be logged.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
