lordgamez commented on PR #1682:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1682#issuecomment-1893634802
> >
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/standard-processors/processors/SplitText.cpp:133:3:
error: function 'getState' should be marked [[nodiscard]]
[modernize-use-nodiscard,-warnings-as-errors]
> > detail::StreamReadState getState() const { return
line_reader_.getState(); }
> > ^
> > [[nodiscard]]
> >
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/standard-processors/processors/SplitText.cpp:138:3:
error: function 'lineSizeWouldExceedMaxFragmentSize' should be marked
[[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
> > bool lineSizeWouldExceedMaxFragmentSize(const
detail::LineReader::LineInfo& line, uint64_t fragment_size) const;
> > ^
> > [[nodiscard]]
>
> Latest CI results. Could you fix these?
Sure, updated in c8972996086b2501d9585950a26bc010a48ff42d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
