rfellows commented on code in PR #8294:
URL: https://github.com/apache/nifi/pull/8294#discussion_r1466795410
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/manager/process-group-manager.service.ts:
##########
@@ -1075,22 +1075,22 @@ export class ProcessGroupManager {
const versionControl = processGroup
.select('text.version-control')
.style('visibility',
self.isUnderVersionControl(processGroupData) ? 'visible' : 'hidden')
- .style('fill', function () {
+ .style('class', function () {
Review Comment:
i think you intended this to be
```suggestion
.attr('class', function () {
```
however, when doing that, it would wipe out the `version-control` class on
the same element (used when determining the selection on line 1076. Might need
to return both with this approach or find a way to concat with the existing
class(es)
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/manager/processor-manager.service.ts:
##########
@@ -669,20 +669,20 @@ export class ProcessorManager {
// update the run status
updated
.select('text.run-status-icon')
- .attr('fill', function (d: any) {
- let fill: string = '#728e9b';
+ .attr('class', function (d: any) {
+ let clazz: string = 'primary-500';
if (d.status.aggregateSnapshot.runStatus === 'Validating') {
- fill = '#a8a8a8';
+ clazz = 'warn-contrast-300';
} else if (d.status.aggregateSnapshot.runStatus === 'Invalid')
{
- fill = '#cf9f5d';
+ clazz = 'accent-A200';
} else if (d.status.aggregateSnapshot.runStatus === 'Running')
{
- fill = '#7dc7a0';
+ clazz = 'accent-200';
} else if (d.status.aggregateSnapshot.runStatus === 'Stopped')
{
- fill = '#d18686';
+ clazz = 'warn-200';
}
- return fill;
+ return clazz;
Review Comment:
I think this is overwriting the `run-status-icon` class already on this
element.
It seems to be preventing the icon from updating when the processor is
started/stopped.
Ports have the same issue.
probably want something like:
```
.attr('class', function (d: any) {
let clazz: string = 'primary-500';
if (d.status.aggregateSnapshot.runStatus === 'Validating') {
clazz = 'warn-contrast-300';
} else if (d.status.aggregateSnapshot.runStatus ===
'Invalid') {
clazz = 'accent-A200';
} else if (d.status.aggregateSnapshot.runStatus ===
'Running') {
clazz = 'accent-200';
} else if (d.status.aggregateSnapshot.runStatus ===
'Stopped') {
clazz = 'warn-200';
}
return `run-status-icon ${clazz}`;
})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
