Re: [PR] [NIFI-12698] dark mode, [NIFI-12687] status history axis label fix [nifi]

[via GitHub]

rfellows commented on PR #8320:
URL: https://github.com/apache/nifi/pull/8320#issuecomment-1921862901

   > > 4. The error (red) color is very bright and jumps off the screen a bit 
too much IMO.
   > > 
   > > <img alt="Screenshot 2024-02-01 at 9 15 42 AM" width="800" 
src="https://private-user-images.githubusercontent.com/713866/301533319-f0b30b73-6720-42d5-8d1d-4cbf2c0bf2ad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY4MDIzMzcsIm5iZiI6MTcwNjgwMjAzNywicGF0aCI6Ii83MTM4NjYvMzAxNTMzMzE5LWYwYjMwYjczLTY3MjAtNDJkNS04ZDFkLTRjYmYyYzBiZjJhZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMjAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDIwMVQxNTQwMzdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MjVhZjEwNDMzYzM1ZWY4ODc0NWYzMTc0MTk0ODliNDE5MTY1MTExZWFjOTBmZTUxN2FkYTYxNTY5ZjUxOGI1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.UzBocogFPlRNSbTjlxLtIFzsNfeWPWEgq_LNKJRQ7y8";>
   > 
   > I pushed a fix for this. Let me know what you think.
   
   I like it more. Maybe a bit too muted, but i prefer it this way compared to 
the other. I won't hold up the PR for it. We can address these kinds of things 
later.
   
   > 
   > > 5. The text color in the Provenance graph is hard to read
   > > 
   > > <img alt="Screenshot 2024-02-01 at 9 48 48 AM" width="258" 
src="https://private-user-images.githubusercontent.com/713866/301543574-e383275a-f12f-4b42-a5e3-c162983cbfe9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY4MDIzMzcsIm5iZiI6MTcwNjgwMjAzNywicGF0aCI6Ii83MTM4NjYvMzAxNTQzNTc0LWUzODMyNzVhLWYxMmYtNGI0Mi1hNWUzLWMxNjI5ODNjYmZlOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMjAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDIwMVQxNTQwMzdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00YTZjZjg5MWZiYmQyMDc1NDM0Y2E5NWZlYTBiMjFiMGJhMTcwMDc1NmI2MGQxMTIyMGZjZjJhMjM0Mjg3YWQxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.VqCrs-nBDdAF43UtKR_e0EzaNbAJZXFh67v86_gljOY";>
   > 
   > I pushed a fix for this too.
   
   Looks good now!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org