mark-bathori commented on code in PR #8250:
URL: https://github.com/apache/nifi/pull/8250#discussion_r1478221782


##########
nifi-nar-bundles/nifi-protobuf-bundle/nifi-protobuf-services/src/main/resources/docs/org.apache.nifi.services.protobuf.ProtobufReader/additionalDetails.html:
##########
@@ -0,0 +1,197 @@
+<!DOCTYPE html>
+<html lang="en">
+    <!--
+      Licensed to the Apache Software Foundation (ASF) under one or more
+      contributor license agreements.  See the NOTICE file distributed with
+      this work for additional information regarding copyright ownership.
+      The ASF licenses this file to You under the Apache License, Version 2.0
+      (the "License"); you may not use this file except in compliance with
+      the License.  You may obtain a copy of the License at
+          http://www.apache.org/licenses/LICENSE-2.0
+      Unless required by applicable law or agreed to in writing, software
+      distributed under the License is distributed on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+      See the License for the specific language governing permissions and
+      limitations under the License.
+    -->
+    <head>
+        <meta charset="utf-8"/>
+        <title>ProtobufReader</title>
+        <link rel="stylesheet" href="../../../../../css/component-usage.css" 
type="text/css"/>
+    </head>
+
+    <body>
+        <p>
+            The ProtobufReader Controller Service reads and parses a Protocol 
Buffers Message from binary format and creates a Record object.
+            The Controller Service must be configured with the same '.proto' 
file that was used for the Message encoding, and the fully qualified
+            name of the Message type including its package (e.g. 
mypackage.MyMessage). The Reader will always generate one record from the input
+            data which represents the provided Protocol Buffers Message type.
+            Further information about Protocol Buffers can be found here:
+            <a href="https://protobuf.dev/";>protobuf.dev</a>

Review Comment:
   The Reader supports both proto2 and proto3 versions, only exception is the 
`GROUPS` feature since the schema reader doesn't support it. This feature was 
already deprecated in proto2 and not included in proto3. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to