markap14 commented on code in PR #8442:
URL: https://github.com/apache/nifi/pull/8442#discussion_r1498391143
##########
nifi-api/src/main/java/org/apache/nifi/processor/util/StandardValidators.java:
##########
@@ -843,7 +843,7 @@ public ValidationResult validate(final String subject,
final String input, final
final boolean validSyntax = pattern.matcher(lowerCase).matches();
final ValidationResult.Builder builder = new
ValidationResult.Builder();
if (validSyntax) {
- final long nanos = FormatUtils.getTimeDuration(lowerCase,
TimeUnit.NANOSECONDS);
+ final long nanos = new TimeFormat().getTimeDuration(lowerCase,
TimeUnit.NANOSECONDS);
Review Comment:
Yeah, I intentionally didn't make the method static, because I was thinking
there were more methods, some of which might benefit from providing a timezone,
etc. But now that the refactoring is complete, the methods are really only
about durations. Probably makes sense to use static methods and name it
`DurationFormat` rather than `TimeFormat`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
