Lehel44 commented on PR #8445: URL: https://github.com/apache/nifi/pull/8445#issuecomment-1965816504
@ravinarayansingh Thanks for making this change. However, I'd like to address a concern regarding its scope as this change only adresses a subset of the issue. Postgres maps `BOOLEAN` types to `BIT` due to historical reasons. By mapping `java.sql.Types.BIT` to `RecordFieldType.Boolean` in `DataTypeUtils::getDataTypeFromSQLTypeValue`, we may encounter a scenario where a field defined as `BIT` in the PostgreSQL table with a size specification such as `BIT(n)` where `n>2` cannot be represented as a `BOOLEAN` type, and is not appropriately converted by the JDBC driver. Consequently, the schema for such a field will also be defined as Boolean. @mattyb149, do you have any thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
