dan-s1 commented on code in PR #8458:
URL: https://github.com/apache/nifi/pull/8458#discussion_r1513620936


##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java:
##########
@@ -1012,7 +1013,7 @@ public void onTrigger(ProcessContext context, 
ProcessSession session) throws Pro
         }
     }
 
-    private Request configureRequest(final ProcessContext context, final 
ProcessSession session, final FlowFile requestFlowFile, URL url) {
+    private Request configureRequest(final ProcessContext context, final 
ProcessSession session, final FlowFile requestFlowFile, String url) {

Review Comment:
   @exceptionfactory Not exactly. Only when creating a URL with the UriUtils 
(v1) / UrlValidator (v2) is there the double encoding. Before my changes to how 
the URL was created there was never a double encoding but if the URL is created 
with the URI seven argument constructor it will always encode "illegal" 
characters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to