lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1522863070
########## extensions/python/PythonConfigState.h: ########## @@ -0,0 +1,50 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <filesystem> +#include <string> + +namespace org::apache::nifi::minifi::extensions::python { + +struct PythonConfigState { + public: + PythonConfigState(PythonConfigState&&) = delete; + PythonConfigState(const PythonConfigState&) = delete; + PythonConfigState& operator=(PythonConfigState&&) = delete; + PythonConfigState& operator=(const PythonConfigState&) = delete; + + bool isPackageInstallationNeeded() const { + return install_python_packages_automatically && !virtualenv_path.empty(); + } + + static PythonConfigState& getInstance() { + static PythonConfigState config; + return config; + } Review Comment: Extracted dependency installation to the `PythonDependencyInstaller` class and moved the dependency install to `PythonCreator`, to install dependencies while processing all the python processor script files in 5b20de2ffdc4d8f2bfd8907d1a47294440a11fc2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
