tpalfy commented on code in PR #8493:
URL: https://github.com/apache/nifi/pull/8493#discussion_r1523369229
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java:
##########
@@ -764,7 +796,15 @@ private void executeDML(final ProcessContext context,
final ProcessSession sessi
}
currentValue = dest;
} else if (currentValue instanceof
String) {
- currentValue = ((String)
currentValue).getBytes(StandardCharsets.UTF_8);
+ final String stringValue =
(String) currentValue;
+
+ if
(BINARY_STRING_FORMAT_BASE64.getValue().equals(binaryStringFormat)) {
+ currentValue =
BaseEncoding.base64().decode(stringValue);
+ } else if
(BINARY_STRING_FORMAT_HEX_STRING.getValue().equals(binaryStringFormat)) {
+ currentValue =
BaseEncoding.base16().decode(stringValue.toUpperCase());
Review Comment:
Yes, I'm thinking about having this change on the 1.x branch.
So not sure what is your suggestion. If we want it on 1.x branch is it okay
to use the Google library?
Or you suggest it's worth the additional work to use vanilla Java on main
and instead of simply doing a cherry-pick, the committer should do the code
rewrite during backport to 1.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
