tpalfy commented on PR #6900: URL: https://github.com/apache/nifi/pull/6900#issuecomment-1994553665
> Hm... Sorry, but I have doubts about this... > > @tpalfy Our access tokens e.g. are valid for 60 minutes only. Due to my understanding, the StandardOauth2AccessTokenProvider.java is intentionally written such that an authentication exception shall never occur at all! It will always automatically refresh any token, BEFORE it will expire (using the refresh window) by just asking it for "the access token" from outside calling `getAccessDetail()`. It will always be valid this way... > > So an authentication exception should IMHO never be intended to occur at all... > > ... > > But simply to have a quickfix für NIFI 1.26 still better than nothing. ;-) Okay, that's fair. I have a PR up with my proposed changes here: https://github.com/apache/nifi/pull/8494 In it's first state it only recreates the mail receiver if an error is encountered. I'm going to update it by keeping the first commit, adding a revert commit and adding a new one that checks if the token has been refreshed. So both approach can be checked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
