szaszm commented on code in PR #1739: URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1532443851
########## libminifi/include/core/json/JsonFlowSerializer.h: ########## @@ -26,12 +26,12 @@ class JsonFlowSerializer : public core::flow::FlowSerializer { explicit JsonFlowSerializer(rapidjson::Document document) : flow_definition_json_(std::move(document)) {} [[nodiscard]] std::string serialize(const core::ProcessGroup& process_group, const core::flow::FlowSchema& schema, const utils::crypto::EncryptionProvider& encryption_provider, - const std::unordered_map<utils::Identifier, std::unordered_map<std::string, std::string>>& overrides) const override; + const core::flow::Overrides& overrides) const override; private: void encryptSensitiveProperties(rapidjson::Value& property_jsons, rapidjson::Document::AllocatorType& alloc, const std::map<std::string, Property>& properties, const utils::crypto::EncryptionProvider& encryption_provider, - std::unordered_map<std::string, std::string> component_overrides) const; + const core::flow::Overrides& overrides, const utils::Identifier& component_id) const; Review Comment: This used to only take the overrides for the specific component, but not it gets all of them. Is this changed intentionally? Why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org