pvillard31 commented on code in PR #8557:
URL: https://github.com/apache/nifi/pull/8557#discussion_r1537687826
##########
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/operations/SNMPTrapReceiver.java:
##########
@@ -46,7 +47,7 @@ public void processPdu(final CommandResponderEvent event) {
final PDU pdu = event.getPDU();
if (isValidTrapPdu(pdu)) {
final ProcessSession processSession =
processSessionFactory.createSession();
- final FlowFile flowFile = createFlowFile(processSession, pdu);
+ final FlowFile flowFile = createFlowFile(processSession, pdu,
event.getPeerAddress());
Review Comment:
Really nitpick but instead of adding an argument, isn't it better to just
use the event object to pass as an argument of the private method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
