greyp9 commented on code in PR #8463: URL: https://github.com/apache/nifi/pull/8463#discussion_r1538319116
########## nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/producer/txn/KafkaProducerWrapper.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.kafka.service.producer.txn; + +import org.apache.kafka.clients.producer.Producer; +import org.apache.kafka.clients.producer.ProducerRecord; +import org.apache.kafka.common.header.Header; +import org.apache.kafka.common.header.internals.RecordHeader; +import org.apache.nifi.kafka.service.api.producer.PublishContext; +import org.apache.nifi.kafka.service.api.record.KafkaRecord; +import org.apache.nifi.kafka.service.producer.ProducerCallback; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Iterator; +import java.util.List; +import java.util.Optional; +import java.util.stream.Collectors; + +/** + * Abstract away the configured transactionality of the PublishKafka producer. + */ +public abstract class KafkaProducerWrapper { + protected final Logger logger = LoggerFactory.getLogger(getClass()); + + protected final Producer<byte[], byte[]> producer; + + public KafkaProducerWrapper(final Producer<byte[], byte[]> producer) { + this.producer = producer; + } + + /** + * Transaction-enabled publish to Kafka involves the use of special Kafka client library APIs. + */ + public abstract void init(); + + public void send(final Iterator<KafkaRecord> kafkaRecords, final PublishContext publishContext, final ProducerCallback callback) { + while (kafkaRecords.hasNext()) { + final KafkaRecord kafkaRecord = kafkaRecords.next(); + producer.send(toProducerRecord(kafkaRecord, publishContext), callback); + callback.send(); + } + logger.trace("send():inFlight"); Review Comment: Maybe not. Are there reasonable project guidelines for how to log things that should be disabled by default, but useful in troubleshooting particular scenarios? Not necessarily suggesting this is one; more of a general question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
