mcgilman commented on code in PR #8565:
URL: https://github.com/apache/nifi/pull/8565#discussion_r1539994109
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##########
@@ -1069,6 +1069,16 @@ export class FlowEffects {
this.actions$.pipe(
ofType(FlowActions.openEditProcessorDialog),
map((action) => action.request),
+ switchMap((request) =>
+
from(this.flowService.getProcessor(request.entity.id)).pipe(
+ map((entity) => {
+ return {
+ ...request,
+ entity
+ };
+ })
+ )
Review Comment:
We do need error handling here, however we haven't considered it yet in
`FlowEffects`. There is a line item for it in NIFI-12400. That said, if you'd
prefer I cover this case here now I will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
