[ https://issues.apache.org/jira/browse/NIFI-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15782989#comment-15782989 ]
ASF GitHub Bot commented on NIFI-3228: -------------------------------------- GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1362 NIFI-3228 added s3.contenttype in PutS3Object Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [X] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pvillard31/nifi NIFI-3228 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1362 ---- commit 72cc8b1d0204b1d2079674f63874e5e4ab88f42c Author: Pierre Villard <pierre.villard...@gmail.com> Date: 2016-12-28T14:26:28Z NIFI-3228 added s3.contenttype in PutS3Object ---- > PutS3Object Does Not Write s3.contenttype Attribute > --------------------------------------------------- > > Key: NIFI-3228 > URL: https://issues.apache.org/jira/browse/NIFI-3228 > Project: Apache NiFi > Issue Type: Bug > Affects Versions: 1.1.0, 1.0.1 > Reporter: James Wing > Priority: Trivial > > The PutS3Object processor documents that it writes the "s3.contenttype" > attribute. There is an integration test for this, > ITPutS3Object.testContentType, but it is failing. I did not find code in > PutS3Object that attempts to write this attribute. > PutS3Object should be fixed to write the attribute, or the documentation and > test should be adjusted to match the behavior. -- This message was sent by Atlassian JIRA (v6.3.4#6332)