scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557839018
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/purple.scss:
##########
@@ -126,15 +38,14 @@ $material-theme-light: mat.define-light-theme(
accent: $material-accent-light,
warn: $warn-light
),
- //typography: mat.define-typography-config(), // TODO: typography
- density: -3
+ density: -1
Review Comment:
UPDATE: ok so our dialogs have set sizes (for example this 'Edit Processor'
dialog is a a medium dialog size with minWidth: 760px and maxWidth: 760px) and
all of our buttons and tables set their own density. So it seems this setting
is not such a global setting and it is not as easy as adjusting it to adjust
the entire density of the app. I will revert it to `-3` for now and maybe in
the future we can support adjusting the density globally via the theme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
