scottyaslan commented on code in PR #8607: URL: https://github.com/apache/nifi/pull/8607#discussion_r1558337332
########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-progress-dialog/change-version-progress-dialog.html: ########## @@ -0,0 +1,51 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<h2 mat-dialog-title>Change Flow Version</h2> +<div class="change-version-progress"> + <mat-dialog-content> + <div class="flex flex-col gap-y-4"> + @if (flowUpdateRequest$ | async; as versionChangeRequest) { + <div class="value"> + @if (versionChangeRequest.request.complete) { + This Process Group version has changed. + } @else { + {{ versionChangeRequest.request.state }} + } + </div> + <div class="w-full flex flex-col items-center"> + <mat-progress-bar + mode="determinate" + [value]="versionChangeRequest.request.percentCompleted"></mat-progress-bar> Review Comment: ```suggestion [mat-accent]="versionChangeRequest.request.percentCompleted" [font-medium]="versionChangeRequest.request.percentCompleted"></mat-progress-bar> ``` ########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-dialog/change-version-dialog.html: ########## @@ -0,0 +1,89 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<h2 mat-dialog-title>Change Version</h2> +<div class="change-version" tabindex="0"> + <mat-dialog-content> + <div class="flex flex-col gap-y-4"> + <div> + <div>Registry</div> + <div class="value">{{ versionControlInformation.registryName }}</div> Review Comment: Since you merged my semantic color PR you need to update this to be: ```suggestion <div class="mat-accent font-medium">{{ versionControlInformation.registryName }}</div> ``` ########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/local-changes-dialog/local-changes-table/local-changes-table.html: ########## @@ -0,0 +1,80 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<div class="local-changes-table h-full flex flex-col"> + <div> + <div class="value">Displaying {{ filteredCount }} of {{ totalCount }}</div> + <form [formGroup]="filterForm"> + <div class="flex pt-2"> + <div class="mr-2"> + <mat-form-field> + <mat-label>Filter</mat-label> + <input matInput type="text" class="small" formControlName="filterTerm" /> Review Comment: Of course as I typed this I see that the summary tables have the filter on the left so it is probably fine. ########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/flow/change-version-progress-dialog/change-version-progress-dialog.html: ########## @@ -0,0 +1,51 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<h2 mat-dialog-title>Change Flow Version</h2> +<div class="change-version-progress"> + <mat-dialog-content> + <div class="flex flex-col gap-y-4"> + @if (flowUpdateRequest$ | async; as versionChangeRequest) { + <div class="value"> Review Comment: ```suggestion <div class="mat-accent font-medium"> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
