szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1560663211


##########
docker/test/integration/cluster/ImageStore.py:
##########
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
 
         return self.__build_image(dockerfile)
 
-    def __build_minifi_cpp_image_with_nifi_python_processors(self, 
additional_cmd=""):
+    def __build_minifi_cpp_image_with_nifi_python_processors(self, 
python_option):
         parse_document_url = 
"https://raw.githubusercontent.com/apache/nifi/rel/nifi-"; + 
NifiContainer.NIFI_VERSION + 
"/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ParseDocument.py"
         chunk_document_url = 
"https://raw.githubusercontent.com/apache/nifi/rel/nifi-"; + 
NifiContainer.NIFI_VERSION + 
"/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ChunkDocument.py"
         pip3_install_command = ""
+        requirements_install_command = ""
+        additional_cmd = ""
+        parse_document_sed_cmd = 'sed -i "54d;55d" 
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/ParseDocument.py
 && \\'
+        chunk_document_sed_cmd = 'sed -i "112d" 
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/ChunkDocument.py
 && \\'

Review Comment:
   ```
   sed -i '/class ProcessorDetails:/,/^$/{/^\s*dependencies\s*=/,/\]\s*$/d}' 
ParseDocument.py
   ```
   `/class ProcessorDetails:/,/^$/`: Do the following between 'class 
ProcessorDetails:' and the first empty line (so we don't modify other 
PropertyDescriptor blocks below)
   `/^\s*dependencies\s*=/,/\]\s*$/`: Do the following between 'dependencies =' 
at the start of a line, and ']' at the end of a line
   `d`: Delete line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to