exceptionfactory commented on code in PR #8630:
URL: https://github.com/apache/nifi/pull/8630#discussion_r1561351573


##########
nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/security/authorization/AuthorizerFactory.java:
##########
@@ -523,6 +523,9 @@ private Authorizer createDefaultAuthorizer() {
         return new Authorizer() {
             @Override
             public AuthorizationResult authorize(final AuthorizationRequest 
request) throws AuthorizationAccessException {
+                if(properties.isReadOnly() && 
!request.getAction().equals(RequestAction.READ)) {

Review Comment:
   Injecting this property check into the default is not an optimal approach 
because it requires evaluating the property on every request, as opposed to 
configuring a specific authorizer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to