[ https://issues.apache.org/jira/browse/NIFI-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783611#comment-15783611 ]
ASF GitHub Bot commented on NIFI-3249: -------------------------------------- Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1356 +1 Visually verified code and did a contrib-check build. In standalone tested many different updateAttribute configurations hitting: regular update, delete, stateful update, and stateful update with advanced rule. All worked as expected. Thanks @brosander I will merge it in. > UpdateAttribute performance improvements > ---------------------------------------- > > Key: NIFI-3249 > URL: https://issues.apache.org/jira/browse/NIFI-3249 > Project: Apache NiFi > Issue Type: Improvement > Reporter: Bryan Rosander > Assignee: Bryan Rosander > Priority: Minor > Attachments: after.png, before.png > > > UpdateAttribute does a lot of work in every onTrigger() that it doesn't need > to. > The default actions map can be built at schedule time so that it doesn't need > to be done on every trigger. > getPropertyValue() can be implemented using ConcurrentMap.computeIfAbsent() > Update actions can be ignored if there is a delete action for the same > attribute. > Only need to call processSession.updateAttributes() and > processSession.deleteAttributes() if there are attributes to update and > delete respectively. -- This message was sent by Atlassian JIRA (v6.3.4#6332)