rfellows commented on code in PR #8643:
URL: https://github.com/apache/nifi/pull/8643#discussion_r1567330535
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/birdseye-view.service.ts:
##########
@@ -311,24 +316,26 @@ export class BirdseyeView {
});
// processors
- this.processorManager.selectAll().each(function (d: any) {
+ this.processorManager.selectAll().each((d:
ComponentEntityWithDimensions) => {
// default color
let color = '#dde4eb';
if (d.permissions.canRead) {
// use the specified color if appropriate
if (d.component.style['background-color']) {
color = d.component.style['background-color'];
-
- // if the background color is #ffffff use the default
instead
- if (color === '#ffffff') {
- color = '#dde4eb';
- }
}
}
+ // determine border color
+ const strokeColor: string =
this.canvasUtils.determineContrastColor(
+ this.nifiCommon.substringAfterLast(color, '#')
+ );
+
context.fillStyle = color;
context.fillRect(d.position.x, d.position.y, d.dimensions.width,
d.dimensions.height);
+ context.strokeStyle = strokeColor;
+ context.strokeRect(d.position.x, d.position.y, d.dimensions.width,
d.dimensions.height);
Review Comment:
we need to do the same for labels above (line 280-293)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
